Revise summary and statement of need for clarity#338
Merged
Alek050 merged 2 commits intoAlek050:joss-paperfrom Jan 21, 2026
Merged
Revise summary and statement of need for clarity#338Alek050 merged 2 commits intoAlek050:joss-paperfrom
Alek050 merged 2 commits intoAlek050:joss-paperfrom
Conversation
Updated the summary and statement of need sections to enhance clarity and correct typographical errors. Improved descriptions of soccer analytics and data parsing functionalities.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## joss-paper #338 +/- ##
=============================================
Coverage ? 99.55%
=============================================
Files ? 65
Lines ? 4971
Branches ? 0
=============================================
Hits ? 4949
Misses ? 22
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the summary and statement of need sections to enhance clarity and correct typographical errors. Improved descriptions of soccer analytics and data parsing functionalities.
I changes some of the wording in the first to sections. I was thinking to maybe also go a bit into the different data representations in kloppy and floodlight compare to databallpy as this is one of the issues why you don´t just include it there but have it as a stand alone.
I would further expand the description of the synchronistion a bit as it is the main feature of the package. Also mentioning the improved running time.
As you said, it misses a " conclussion" to highlight again what makes it stand out.